logrus logging bridge #5356
Merged
logrus logging bridge #5356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5356 +/- ##
=======================================
+ Coverage 62.7% 63.1% +0.3%
=======================================
Files 192 193 +1
Lines 11786 11892 +106
=======================================
+ Hits 7399 7504 +105
- Misses 4170 4171 +1
Partials 217 217
|
dmathieu
requested review from
MrAlias,
MadVikingGod,
pellared and
dashpole
as code owners
hanyuancheung
approved these changes
Apr 14, 2024
pellared
reviewed
Apr 24, 2024
There was a problem hiding this comment.
It would be good to increase the test coverage.
In my opinion we should also add a test example. It may help not only the users but also other reviewers to understand how it is supposed to be used.
It would be good to add benchmarks, but this would be better added as a separate PR. I do not think it is a must-have given that logrus is not used in performance-critical applications.
pellared
reviewed
Apr 24, 2024
pellared
reviewed
Apr 25, 2024
pellared
approved these changes
Apr 25, 2024
MadVikingGod
approved these changes
May 6, 2024
XSAM
reviewed
May 7, 2024
dmathieu
force-pushed
the
otellogrus
branch
2 times, most recently
from
e0cd368
to
502f48d
Compare
pellared
reviewed
May 7, 2024
pellared
reviewed
May 7, 2024
This was referenced May 7, 2024
pellared
approved these changes
May 10, 2024
Co-authored-by: Robert Pająk <pellared@hotmail.com>
zailic
pushed a commit
to zailic/opentelemetry-go-contrib
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5193.
This adds the logrus log bridge